Add multi-account support and update project docs
- Add SavedAccount/AccountStore and rework ServerProvider around a list of saved accounts: switch/remove/add, swipe-to-cycle on the avatar button, per-account browsing prefs (sort/view/filters/cache), and a session-generation guard so a stale fetch from an abandoned account can't land in the newly active one - Migrate existing single-account installs into the new schema automatically so upgrading users stay logged in - Settings gains an Accounts section; LoginView gains an "add account" mode pushed on top of the main shell instead of replacing it - Give every Scrollbar in the app a thicker, draggable, Android-style thumb via a shared ScrollbarTheme instead of the default hairline - Splash screen: use the monochrome app icon (tinted per theme) and a smaller spinner - Update CLAUDE.md and .claude/context/*.md to reflect the accumulated multi-account, sharing, and UI changes across this session, and add a standing instruction to keep these docs current going forward Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
+89
-22
@@ -9,12 +9,18 @@ via [`LoginFlowService`](../../lib/services/login_flow_service.dart):
|
||||
1. `LoginFlowService.initiate(serverUrl)` POSTs to
|
||||
`{server}/index.php/login/v2`, gets back a browser login URL + a poll
|
||||
endpoint/token.
|
||||
2. The app opens the login URL in the system browser (`url_launcher`); the
|
||||
user authenticates and authorizes there.
|
||||
2. The app opens the login URL in a Chrome Custom Tab (`url_launcher`,
|
||||
`LaunchMode.inAppBrowserView` — real Chrome, so saved passwords/autofill
|
||||
work, unlike Flutter's own embedded web view); the user authenticates and
|
||||
authorizes there. There's no way to close the tab automatically on
|
||||
success (Login Flow v2 never redirects back into the app, and a Custom
|
||||
Tab belongs to Chrome's own task) — the user switches back manually.
|
||||
3. `ServerProvider` polls `LoginFlowService.poll(pollEndpoint, token)` every
|
||||
2 seconds (`Timer.periodic`, see `_pollTimer`/`_pollTimeoutTimer` in
|
||||
`server_provider.dart`) until it gets a 200 with `server`/`loginName`/
|
||||
`appPassword`, a non-404 error, or a 10-minute timeout.
|
||||
`appPassword`, a non-404 error, or a 10-minute timeout. A single dropped
|
||||
connection mid-poll (`http.ClientException`) is swallowed and retried on
|
||||
the next tick rather than aborting the whole flow.
|
||||
4. The returned **app password** (scoped, revocable) is what gets stored and
|
||||
used for every subsequent request — real user passwords are never in
|
||||
memory or on disk.
|
||||
@@ -23,41 +29,102 @@ via [`LoginFlowService`](../../lib/services/login_flow_service.dart):
|
||||
drives `LoginView`'s UI; see `LoginFlowService`'s doc comment for the full
|
||||
flow rationale before changing it.
|
||||
|
||||
`startLoginFlow(serverUrl, {addAccount = false})` is reused verbatim for
|
||||
both the first/only login and "add another account" (pushed from Settings
|
||||
while already logged into a different account, `LoginView(isAddingAccount:
|
||||
true)`) — `addAccount` only flags `isAddAccountFlow` for the UI (so the
|
||||
pushed screen knows to auto-pop on success and cancel the flow on
|
||||
back-swipe); the persistence path on success is identical either way, see
|
||||
below.
|
||||
|
||||
## Talking to the server
|
||||
|
||||
[`NextcloudService`](../../lib/services/nextcloud_service.dart) is the
|
||||
client for an authenticated session — constructed with `serverUrl` +
|
||||
`username` + the app password, one instance per login (held as
|
||||
`ServerProvider.service`, recreated on login/logout).
|
||||
`ServerProvider.service`, recreated on every login/switch/logout). It's
|
||||
effectively stateless per-instance (three final fields, headers rebuilt per
|
||||
request), which is what makes it trivial to have one saved per account
|
||||
rather than needing a rewrite for multi-account support.
|
||||
|
||||
- **Files**: WebDAV (`PROPFIND`/`MKCOL`/`DELETE`/`MOVE` etc. against
|
||||
- **Files**: WebDAV (`PROPFIND`/`MKCOL`/`DELETE`/`MOVE`/`PUT` etc. against
|
||||
`/remote.php/dav/files/{username}/...`) via raw `http`/`dio` calls with a
|
||||
hand-rolled XML request body and `package:xml` for parsing responses —
|
||||
there is no WebDAV client dependency. `_parseDavDate`/`_davPath` in this
|
||||
file exist because WebDAV responses use RFC 1123 dates and either bare
|
||||
paths or full URLs for `href`; reuse them rather than re-deriving.
|
||||
- **Everything else** (shares, activity, trash, favorites, quota, user info)
|
||||
goes through Nextcloud's OCS APIs (`/ocs/v2.php/...`), JSON in, with the
|
||||
`OCS-APIRequest: true` header required on every OCS call.
|
||||
- **Everything else** (shares, activity, trash, favorites, quota, user info,
|
||||
file versions) goes through Nextcloud's OCS APIs (`/ocs/v2.php/...`), JSON
|
||||
in, with the `OCS-APIRequest: true` header required on every OCS call.
|
||||
- Auth header is HTTP Basic (`username:appPassword`, base64), built in
|
||||
`_headers`/exposed as `authHeaders` for widgets that need to hit URLs
|
||||
directly (e.g. `Image.network(url, headers: service.authHeaders)` for
|
||||
thumbnails/previews).
|
||||
- Downloads stream through `Dio` (`downloadToFile`) for progress callbacks;
|
||||
small in-app previews (text/PDF) use `fetchBytes` via `package:http`.
|
||||
- **Uploads** (`uploadFileFromPath(folderPath, fileName, localFilePath,
|
||||
{onProgress})`) stream the local file via `Dio().put()` with an explicit
|
||||
`Content-Length` and `onSendProgress`, mirroring the download path. The
|
||||
`ServerProvider` wrapper always uploads into `_currentFolderPath` — the
|
||||
share-to-upload flow (`ShareUploadView`) gets a caller-chosen destination
|
||||
by navigating there first (`navigateToAbsoluteFolder`), then uploading.
|
||||
- **Receiving a shared file from another app**: `receive_sharing_intent`
|
||||
(Android `ACTION_SEND`/`ACTION_SEND_MULTIPLE`, `android:launchMode`
|
||||
`singleTask` in the manifest so a second share while running hits
|
||||
`onNewIntent` instead of spawning a new instance). `MainShellView` listens
|
||||
via `getInitialMedia()`/`getMediaStream()` and pushes `ShareUploadView`,
|
||||
which reuses the same `uploadFileFromPath` path after the user picks a
|
||||
destination folder.
|
||||
|
||||
## Session persistence
|
||||
## Multi-account storage & session persistence
|
||||
|
||||
- **Credentials** (`server`, `loginName`, `appPassword`) live in
|
||||
`flutter_secure_storage` — OS keychain/keystore-backed, never
|
||||
`shared_preferences`.
|
||||
- **UI/app preferences** (theme mode, seed color, dynamic-color toggle,
|
||||
bottom-bar opacity/blur, grid vs. list, sort field, hidden-files toggle,
|
||||
etc.) live in `shared_preferences` — see the `_pref*` key constants at the
|
||||
top of `server_provider.dart`.
|
||||
- On startup, `ServerProvider._restoreSession()` reads the secure-storage
|
||||
keys and, if all three are present, rebuilds a `NextcloudService` without
|
||||
re-hitting the login flow (`_applyCredentials(..., persist: false)`).
|
||||
`isRestoringSession` gates the splash screen until this resolves — see
|
||||
`standards.md` for why widget tests must mock both storage channels
|
||||
rather than relying on this async path throwing naturally.
|
||||
[`AccountStore`](../../lib/services/account_store.dart) owns everything
|
||||
account-identity-related; `ServerProvider` owns everything about which
|
||||
account is *currently* live (see `architecture.md`).
|
||||
|
||||
- **Per-account secrets**: one `flutter_secure_storage` key per account,
|
||||
`nc_app_password_<accountId>` — never `shared_preferences`. `accountId` is
|
||||
deterministic (`SavedAccount.makeId(serverUrl, username)`, a slug of both),
|
||||
so re-adding the same account refreshes its password instead of creating a
|
||||
duplicate.
|
||||
- **Account identity list** (non-secret: id/serverUrl/username) and
|
||||
**which one is active** live in `shared_preferences` as `accounts_list`
|
||||
(JSON array) and `active_account_id`.
|
||||
- **Global UI prefs** (theme, dynamic color, AMOLED, bottom-bar
|
||||
opacity/blur, tap-to-scroll-top, seek bar style, tab order/hidden/default,
|
||||
swipe actions) stay flat, un-namespaced `shared_preferences` keys — same
|
||||
as before multi-account, untouched by switching.
|
||||
- **Per-account browsing prefs** (grid/list view, favorites-only ×2,
|
||||
storage scope, show-hidden ×2, Photos sort field/ascending, Files'
|
||||
per-folder sort map, cache policy/interval — the full list is
|
||||
`AccountStore.perAccountPrefKeys`) are namespaced `acct_<accountId>_<key>`
|
||||
and reloaded on every switch via `ServerProvider._applyAccountPrefs`.
|
||||
- **Legacy migration**: `AccountStore.migrateLegacyIfNeeded` runs once ever
|
||||
(guarded by the `account_migration_v1_done` flag), turning a pre-multi-
|
||||
account install's 3 flat secure-storage keys + flat browsing prefs into
|
||||
the first saved (and active) account, so upgrading users are never logged
|
||||
out. Never assume the legacy keys are gone — always check the migration
|
||||
flag rather than the keys' absence.
|
||||
- On startup, `ServerProvider._init()` awaits the migration, loads the
|
||||
account list + active id, then `_restoreSession()` looks up the active
|
||||
account's password and calls `_applyCredentialsForAccount` (the renamed,
|
||||
generation-guarded, account-aware version of what used to be
|
||||
`_applyCredentials`) to rebuild the session without re-hitting the login
|
||||
flow.
|
||||
- **Switching accounts** (`switchAccount`/`cycleToNextAccount`/
|
||||
`cycleToPreviousAccount`/`removeAccount`'s fallback, plus landing on a
|
||||
freshly-added account) all funnel through the single `_activateAccount`
|
||||
engine: bump `_sessionGeneration`, cancel any pending login flow, clear
|
||||
every content field *without* ever setting `isLoggedIn` false (that's the
|
||||
detail that keeps `main.dart`'s root routing from bouncing through
|
||||
`LoginView` mid-switch), reload the target account's prefs, then verify
|
||||
its credentials and refetch everything. This is a full teardown-and-reload
|
||||
every time — there is deliberately no simultaneous multi-account state or
|
||||
background sync; only one account's content is ever live.
|
||||
- `logout()` is just `removeAccount(activeAccountId)` — with other accounts
|
||||
saved it falls back to one of them instead of ending the session;
|
||||
`isLoggedIn` only ever becomes `false` when the *last* account is removed.
|
||||
|
||||
`isRestoringSession` still gates the splash screen until the above resolves
|
||||
— see `standards.md` for why widget tests must mock both storage channels
|
||||
rather than relying on this async path throwing naturally.
|
||||
|
||||
Reference in New Issue
Block a user